Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

groups all six previous fursuits in game into one variant-ized item, with some added extras. #75755

Merged
merged 12 commits into from
Dec 6, 2024

Conversation

7erracotta
Copy link
Contributor

@7erracotta 7erracotta commented Aug 16, 2024

Summary

Content "combines all four previous fursuits into one item through variants"

Purpose of change

Variants are pretty cool, but these bad boys over here predated them, it seems fitting to group them all under one item now. I added a couple extra just for fun.

Describe the solution

Through some json shenanigans, all previous fursuits (shark suit, feline suit, dino suit, wolf suit, and dragon suit) now share a singular item.

Describe alternatives you've considered

Testing

after hours of shedding blood, sweat, and tears (not really). I popped into the debug console and tested the item groups to ensure they spawned correctly, which they thankfully did.

Additional context

N/A

combines all four previous fursuits into one item through variants. Also added a couple more variants just because. ( I was feeling a little silly, your honor)
@7erracotta 7erracotta changed the title groups all previous four fursuits in game into one variant-ized item, with some added extras. groups all six previous fursuits in game into one variant-ized item, with some added extras. Aug 16, 2024
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Missions Quests and missions Items: Food / Vitamins Comestibles and drinks Spawn Creatures, items, vehicles, locations appearing on map Monsters Monsters both friendly and unfriendly. Items: Armor / Clothing Armor and clothing labels Aug 16, 2024
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • An intricately designed full-body fursuit made to resemble an anthropomorphic bengal tiger, you can't imagine how long it took for it's maker to sew all those stripes onto it. It is quite encumbering and has little storage but is very warm.
  • beaver fursuits
  • dinosaur fursuits
  • dog fursuits
  • dragon fursuits
  • feline fursuits
  • fursuits
  • lizard fursuits
  • orca fursuits
  • otter fursuits
  • shark fursuits
  • tiger fursuits
  • wolf fursuits

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

7erracotta and others added 3 commits August 16, 2024 19:43
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Aug 17, 2024
@Holli-Git
Copy link
Contributor

Holli-Git commented Aug 17, 2024

You need to migrate the previous item IDs, or else saves will break

@Maddremor
Copy link
Contributor

Might I suggest removing the shark fursuit entirely given that the shark suit of the diving variety is already in the game?

@Night-Pryanik
Copy link
Contributor

@7erracotta could you please resolve conflicts?

7erracotta and others added 2 commits November 13, 2024 15:48
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Nov 14, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 14, 2024
@7erracotta
Copy link
Contributor Author

Is there any other changes I need to make? Im confused on what else needs to be done

@Night-Pryanik
Copy link
Contributor

No. Sorry for the delay.

@Night-Pryanik Night-Pryanik merged commit 67439f6 into CleverRaven:master Dec 6, 2024
18 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Items: Armor / Clothing Armor and clothing Items: Food / Vitamins Comestibles and drinks [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Missions Quests and missions Monsters Monsters both friendly and unfriendly. Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants