Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small bark audit - fixing bark resource density #75550

Merged
merged 1 commit into from
Aug 11, 2024

Conversation

Karol1223
Copy link
Contributor

Summary

None

Purpose of change

While working on #75311 I noticed our bark resources have bad densities. That didn't make me feel very warm and fuzzy inside, so I chose violence.

Describe the solution

  • Added a new bark abstract, since all of our bark items shared all fields but the ID, name, and description. Willowbark and alder bark also had barter value, but I chose to throw that out the window, since I can't exactly see anyone paying for that when they can just go and tear it off the tree themselves
  • The bark abstract has all non-unique fields the same as old alder bark did, with the exception of barter price which is set to 0 like how tanbark had it
  • Made the 4 vanilla bark resource items copy from the abstract, removed the 3 breaking density tests from the bad density list
  • Renamed all of them to piece of [bark] for nicer pluralization. I fucking love pluralization

Describe alternatives you've considered

Testing

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Code: Tests Measurement, self-control, statistics, balancing. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 9, 2024
@Maleclypse Maleclypse merged commit 2d4e043 into CleverRaven:master Aug 11, 2024
21 of 26 checks passed
@Karol1223 Karol1223 deleted the bark branch August 11, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Tests Measurement, self-control, statistics, balancing. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants