Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handheld game system disassembly changes + Updates to disassembly documentation #75395

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

Karol1223
Copy link
Contributor

Summary

None

Purpose of change

The enigma of why handheld game consoles were depressing to disassemble has been cracked by @RenechCDDA - it was that because they were a reversible craft, they had a difficulty of 8 which impacted the time it took to disassemble them. Or something like that. Anyway the difficulty was at blame. Also turns out I missed a crucial piece of information when writing the disassembly documentation.

Describe the solution

  • Update the item disassembly documentation to correct some mistakes and mention the integration of uncrafts and reversible crafts
  • Replace the reversible craft for the handheld game system with a manual uncraft - this is very similar, the difference is it no longer has a stupidly high difficulty floor and no longer needs soldering (instead needs cutting to cut apart the plastic)

Describe alternatives you've considered

Using the integration of reversible crafts and uncrafts for the handheld game system, but there's really no reason to use it for that specific craft since it doesn't have any arrays or requirement groups that could warrant this. soldering_standard wouldn't produce any more results from disassembling.

Testing

Additional context

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON [Markdown] Markdown issues and PRs astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Aug 2, 2024
@Karol1223 Karol1223 closed this Aug 2, 2024
@Karol1223 Karol1223 reopened this Aug 2, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 2, 2024
@Maleclypse Maleclypse merged commit 44d1431 into CleverRaven:master Aug 6, 2024
37 of 49 checks passed
@Karol1223 Karol1223 deleted the console-disassembly branch August 6, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants