Clean up personality "magic numbers"-->defined constants #75382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
NPC / Factions
github-actions
bot
added
the
BasicBuildPassed
RenechCDDA
force-pushed
the
remove_npc_personality_magic_numbers
branch
from
48082ae to
af51f20
Compare
github-actions
bot
removed
the
BasicBuildPassed
RenechCDDA
force-pushed
the
remove_npc_personality_magic_numbers
branch
from
af51f20 to
30a79be
Compare
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
In #70314 I introduced constants to define the minimum and maximum allowed personality scores. However there were still some places I missed.
Describe the solution
Look through all the string results for
personalityand clean them up. Replace magic numbers with the constant. Much easier to change in the future if we want to change that range, and no need to wonder if-10really was supposed to be tied to personality or not.Describe alternatives you've considered
The debug menu still (purposefully) allows you to enter values outside of the expected range. I did not see a need to change this, but maybe I could add a note or something for the normal range.
Testing
It compiles and loads without error. Generated a few NPCs, didn't see anything outside of the -10, 10 range.
Additional context
There should be no functional changes.