Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow stereo system and some other small parts to be installed in aircraft #75360

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

Consoleable
Copy link
Contributor

added SIMPLE_PART flag to locks, clocks, and stereo system

Summary

Features "Allow some small parts on helicopters"

Purpose of change

Some small("<1kg & <5L) parts were added to the list of parts which can be installed on helicopters.

Describe the solution

Add the "SIMPLE_PART" flag to these parts. It doesn't seem to do anything else.

Describe alternatives you've considered

Testing

added flag to parts jsons, tested flight & installation, seems to work in basic build

Additional context

Helicopters are dangerous and complex vehicles. Installing heavy and bulky vehicle parts on aircraft are prohibited for good reason. However, the list of things that can be installed is too-conservative, especially when it comes to small internal parts which have less of an impact than the cargo people are stuffing into helicopter boxes. The "SIMPLE_PART" flag is too vague and isn't really based on a criteria that i can figure out. Balancing parts installable on aircraft should be revisited.

added SIMPLE_PART flag to locks, clocks, and stereo system
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Vehicles Vehicles, parts, mechanics & interactions <Enhancement / Feature> New features, or enhancements on existing astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Aug 1, 2024
@Consoleable Consoleable marked this pull request as ready for review August 1, 2024 04:22
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 1, 2024
@dseguin dseguin merged commit fc96523 into CleverRaven:master Aug 2, 2024
35 of 41 checks passed
@Consoleable Consoleable deleted the Pimp-my-Flight branch August 2, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants