Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose instability to json #75330

Merged
merged 3 commits into from
Aug 2, 2024

Conversation

GuardianDll
Copy link
Member

@GuardianDll GuardianDll commented Jul 30, 2024

Summary

None

Purpose of change

Json power

Describe the solution

Make ROBUST_GENETIC check the flag
Add enchantment, that modifies the result of get_instability_per_category

Testing

without test mutation applied
image
next second, with test mutation applied
image

Additional context

image
Would be funny if psionic mutation counted as very bad mutations for instability purposes

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies [C++] Changes (can be) made in C++. Previously named `Code` [Markdown] Markdown issues and PRs Mechanics: Enchantments / Spells Enchantments and spells labels Jul 30, 2024
@github-actions github-actions bot requested a review from KorGgenT July 30, 2024 17:07
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jul 30, 2024
@Standing-Storm
Copy link
Contributor

Would be funny if psionic mutation counted as very bad mutations for instability purposes

XEDRA-23 researchers in shambles.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jul 30, 2024
doc/MAGIC.md Outdated Show resolved Hide resolved
@dseguin dseguin merged commit 1c3f49f into CleverRaven:master Aug 2, 2024
22 of 27 checks passed
@GuardianDll GuardianDll deleted the instability_enchantment branch August 2, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs Mechanics: Enchantments / Spells Enchantments and spells Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants