Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MoM] Change Voltaic Strikes and Electrical Discharge to concentration #75313

Merged
merged 2 commits into from
Jul 30, 2024
Merged

[MoM] Change Voltaic Strikes and Electrical Discharge to concentration #75313

merged 2 commits into from
Jul 30, 2024

Conversation

Standing-Storm
Copy link
Contributor

Summary

Mods "[MoM] Change Voltaic Strikes and Electrical Discharge to concentration"

Purpose of change

Same logic as #75305, the concentration model is pretty well-balanced at this point so more powers should be converted over to it.

Describe the solution

Switch Voltaic Strikes and Electrical Discharge to concentration

Describe alternatives you've considered

Testing

Both powers remain on indefinitely, turn off if you rechannel or use Stop Concentration, and increment the concentration counter

Additional context

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding [Markdown] Markdown issues and PRs EOC: Effects On Condition Anything concerning Effects On Condition Mods: Mind Over Matter astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jul 29, 2024
@Maleclypse Maleclypse merged commit 8062226 into CleverRaven:master Jul 30, 2024
24 checks passed
@Standing-Storm Standing-Storm deleted the electro-concentratiron branch July 30, 2024 14:19
@Terrorforge Terrorforge mentioned this pull request Aug 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Documentation> Design documents, internal info, guides and help. EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs Mods: Mind Over Matter Mods Issues related to mods or modding
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Standing-Storm @Maleclypse