Place_vending function can place unpowered machines #75078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Map / Mapgen
github-actions
bot
added
<Enhancement / Feature>
github-actions
bot
added
the
BasicBuildPassed
|
Needs conflict resolution |
John-Candlebury
force-pushed
the
place-vending
branch
from
2ee8cd8 to
4467769
Compare
This was referenced Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Features "Place_vending function can place unpowered machines"
Purpose of change
Allow the placement of vending machines while accounting for whether the structure they are placed in is powered/unpowered,
Describe the solution
Add a new "powered" bool that governs the placement of powered/unpowered machines.
Atm this will only add the new functionality and fix aftershock. @GuardianDll probably has a better grasp of which machines should be powered in vanilla, since they have already made this audit. All other vending machines will spawn unpowered.
Describe alternatives you've considered
It takes me longer to make maps in perpetuity (it already takes me a long while).
Testing
Visited both port agustmoon and a microlab, vending machines spawned as expected.