-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[XE] Add more quests to Boann and add a way to get out of the world #75040
Merged
Maleclypse
merged 38 commits into
CleverRaven:master
from
SariusSkelrets:More_Boann_Quests
Jul 20, 2024
Merged
[XE] Add more quests to Boann and add a way to get out of the world #75040
Maleclypse
merged 38 commits into
CleverRaven:master
from
SariusSkelrets:More_Boann_Quests
Jul 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
Changes (can be) made in JSON
Mods
Issues related to mods or modding
Mods: Xedra Evolved
Anything to do with Xedra Evolved
astyled
astyled PR, label is assigned by github actions
labels
Jul 15, 2024
SariusSkelrets
changed the title
Begin preparing the dialogue for the new quests
[XE] Add more quests to Boann and add a way to get out of the world
Jul 15, 2024
github-actions
bot
added
Mutations / Traits / Professions/ Hobbies
Mutations / Traits / Professions/ Hobbies
Mechanics: Enchantments / Spells
Enchantments and spells
EOC: Effects On Condition
Anything concerning Effects On Condition
labels
Jul 16, 2024
github-actions
bot
added
Crafting / Construction / Recipes
Includes: Uncrafting / Disassembling
Spawn
Creatures, items, vehicles, locations appearing on map
Monsters
Monsters both friendly and unfriendly.
labels
Jul 16, 2024
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to Hints for adding a new word to the dictionary
|
…/Cataclysm-DDA into More_Boann_Quests
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions
bot
added
the
json-styled
JSON lint passed, label assigned by github actions
label
Jul 19, 2024
github-actions
bot
removed
the
json-styled
JSON lint passed, label assigned by github actions
label
Jul 19, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions
bot
added
the
json-styled
JSON lint passed, label assigned by github actions
label
Jul 19, 2024
github-actions
bot
removed
the
json-styled
JSON lint passed, label assigned by github actions
label
Jul 19, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions
bot
added
the
json-styled
JSON lint passed, label assigned by github actions
label
Jul 19, 2024
github-actions
bot
removed
the
json-styled
JSON lint passed, label assigned by github actions
label
Jul 19, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions
bot
added
json-styled
JSON lint passed, label assigned by github actions
and removed
json-styled
JSON lint passed, label assigned by github actions
labels
Jul 19, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions
bot
added
the
json-styled
JSON lint passed, label assigned by github actions
label
Jul 19, 2024
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Jul 20, 2024
Maleclypse
reviewed
Jul 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
Crafting / Construction / Recipes
Includes: Uncrafting / Disassembling
EOC: Effects On Condition
Anything concerning Effects On Condition
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Mechanics: Enchantments / Spells
Enchantments and spells
Mods: Xedra Evolved
Anything to do with Xedra Evolved
Mods
Issues related to mods or modding
Monsters
Monsters both friendly and unfriendly.
Mutations / Traits / Professions/ Hobbies
Mutations / Traits / Professions/ Hobbies
Spawn
Creatures, items, vehicles, locations appearing on map
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mods "Add more quests to Boann and the possibility to leave the world"
Purpose of change
Boann needs more quests before the player is allowed to follow her out of this doomed world. This add them
Describe the solution
Add the new quests and their rewards
Find and kill two march lords:
Kill the suspicious dog (thing)
Find and kill five Mi-Go guards
Kill an armored centipede
Kill the remains of a dreamforged automaton
.
The Jabberwock quest is part of the easy ones above
Bring back a chunk of a triffid heart
Kill a titan stag bettle
Bring back a piece of the darkest shadow (from A Shadow?)
Kill a star-crowned hound
.
Describe alternatives you've considered
None
Testing
The dialogue works as expected, no errors or missing dialogue
The rewards work as intended and are granted by the missions
March lords: It takes at most two offices to complete, when killed the rewards are available
Dog (thing): it appears in its first form, when its final form dies the mission is completed and rewards are available
Find and kill five Mi-Go guards: The mission points to an encampment containing enough guards to complete it in one go, when killed the rewards are available
Kill an armored centipede: It spawns, when killed the rewards are available
Kill the remains of a dreamforged automaton: It spawns, it sparks, it speaks, when killed the rewards are available
Chunk of a triffid heart: butchery drops the heart chunks, they allow to complete the mission
Titan stag bettle: It spawns, when killed the rewards are available
A Shadow?: it spawns and works as expected, when slain the player gains the quest item, that item allows to complete the mission
Star-crowned hound: It spawns, when killed the rewards are available, it is possible to kill it with only unmodded + XE
The player can be brought out of this world alone or with followers (light text change if player has followers and wish to bring them offworld) when completing all the quests and not before
Both options end the game
Additional context
I won't add the Liam dialogue in this PR, because I already expect it to be quite long before that
Same for paraclesian-exclusive dialogue and the unique "tombstone"
The dots in the checklist are here to fix the formating