Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XE] Add more quests to Boann and add a way to get out of the world #75040

Merged
merged 38 commits into from
Jul 20, 2024
Merged

[XE] Add more quests to Boann and add a way to get out of the world #75040

merged 38 commits into from
Jul 20, 2024

Conversation

SariusSkelrets
Copy link
Contributor

@SariusSkelrets SariusSkelrets commented Jul 15, 2024

Summary

Mods "Add more quests to Boann and the possibility to leave the world"

Purpose of change

Boann needs more quests before the player is allowed to follow her out of this doomed world. This add them

Describe the solution

Add the new quests and their rewards

Find and kill two march lords:

  • Make the mission
  • Add the dialogue
  • Implement the reward (a trait that can be activated once a day to summon 5 allied dafodil. They last one day before disappearing)

Kill the suspicious dog (thing)

  • Make the mission
  • Add the dialogue
  • Implement the reward (the glass-using clairvoyance hedge magic spell, currently unobtainable otherwise)

Find and kill five Mi-Go guards

  • Make the mission
  • Add the dialogue
  • Implement the reward (a mana-granting artifact, similar to the dreamer's version)

Kill an armored centipede

  • Make the mission
  • Add the dialogue
  • Implement the reward (Boann's insigna: an item activable once per day that produces milk and shelled hazelnuts)

Kill the remains of a dreamforged automaton

  • Make the mission
  • Create the automaton
  • Add the dialogue
  • Make the mission give a frostrimmed estoc
    .
  • When knighted (all missions above are completed), Boann offers harder missions (and not before that)
    The Jabberwock quest is part of the easy ones above

Bring back a chunk of a triffid heart

  • Make the mission
  • Create the heart chunk item
  • Add the dialogue
  • Make the mission give a full set of verdant armor (currently arvore-only otherwise)

Kill a titan stag bettle

  • Make the mission
  • Add the dialogue
  • Make the mission give a non-replica Väinämöinen's Kantele (currently unobtainable otherwise)

Bring back a piece of the darkest shadow (from A Shadow?)

  • Make the mission
  • Add the dialogue
  • Ensure the text is clear as day on the target
  • Make that shadow drop an item when killed
  • Ensure the quest can be completed if the shadow is killed before the mission is accepted
  • Implement the reward (Boann's banner: an item activable once per day that stops time for 9 seconds when used)

Kill a star-crowned hound

  • Make the mission
  • Add the dialogue
  • Implement the reward (a necklace that increases dreamer and eater spell levels by five while worn)
    .
  • Ensure that the option to end the game by going offworld works and properly ends the game
  • Make the advices accessible from the first dialogue option
  • Make player unable to ask how to get out of the world or to check for quests if they can chose to get out of the world

Describe alternatives you've considered

None

Testing

The dialogue works as expected, no errors or missing dialogue

The rewards work as intended and are granted by the missions

March lords: It takes at most two offices to complete, when killed the rewards are available

Dog (thing): it appears in its first form, when its final form dies the mission is completed and rewards are available

Find and kill five Mi-Go guards: The mission points to an encampment containing enough guards to complete it in one go, when killed the rewards are available

Kill an armored centipede: It spawns, when killed the rewards are available

Kill the remains of a dreamforged automaton: It spawns, it sparks, it speaks, when killed the rewards are available

Chunk of a triffid heart: butchery drops the heart chunks, they allow to complete the mission

Titan stag bettle: It spawns, when killed the rewards are available

A Shadow?: it spawns and works as expected, when slain the player gains the quest item, that item allows to complete the mission

Star-crowned hound: It spawns, when killed the rewards are available, it is possible to kill it with only unmodded + XE

The player can be brought out of this world alone or with followers (light text change if player has followers and wish to bring them offworld) when completing all the quests and not before
Both options end the game

Additional context

I won't add the Liam dialogue in this PR, because I already expect it to be quite long before that

Same for paraclesian-exclusive dialogue and the unique "tombstone"

The dots in the checklist are here to fix the formating

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Xedra Evolved Anything to do with Xedra Evolved astyled astyled PR, label is assigned by github actions labels Jul 15, 2024
@SariusSkelrets SariusSkelrets changed the title Begin preparing the dialogue for the new quests [XE] Add more quests to Boann and add a way to get out of the world Jul 15, 2024
@github-actions github-actions bot added Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies Mechanics: Enchantments / Spells Enchantments and spells EOC: Effects On Condition Anything concerning Effects On Condition labels Jul 16, 2024
@github-actions github-actions bot added Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Spawn Creatures, items, vehicles, locations appearing on map Monsters Monsters both friendly and unfriendly. labels Jul 16, 2024
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • A broken robot, still standing and saturated with electricity. Between the shattered dreamdross plates, the ruined armor and the electrical discharges, you can barely see the remains of the machinery that once animated it, and yet it moves on its two feets, albeit like some sort of puppet.
  • The automaton is now much more broken than it was before. It ressembles a pile of random parts and its internals are fried beyond salvage but could be gutted for materials.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@SariusSkelrets SariusSkelrets marked this pull request as ready for review July 19, 2024 16:37
@github-actions github-actions bot requested a review from Maleclypse July 19, 2024 16:37
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Jul 19, 2024
@github-actions github-actions bot removed the json-styled JSON lint passed, label assigned by github actions label Jul 19, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Jul 19, 2024
@github-actions github-actions bot removed the json-styled JSON lint passed, label assigned by github actions label Jul 19, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Jul 19, 2024
@github-actions github-actions bot removed the json-styled JSON lint passed, label assigned by github actions label Jul 19, 2024
SariusSkelrets and others added 2 commits July 19, 2024 13:57
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions and removed json-styled JSON lint passed, label assigned by github actions labels Jul 19, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Jul 19, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jul 20, 2024
@Maleclypse Maleclypse merged commit 6ca95f0 into CleverRaven:master Jul 20, 2024
21 of 25 checks passed
@SariusSkelrets SariusSkelrets deleted the More_Boann_Quests branch July 20, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mechanics: Enchantments / Spells Enchantments and spells Mods: Xedra Evolved Anything to do with Xedra Evolved Mods Issues related to mods or modding Monsters Monsters both friendly and unfriendly. Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants