Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magiclysm] Fix Spell Casting Proficiencies not progressing #74798

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

QuillInkwell
Copy link
Contributor

Summary

Mods "[Magicylsm] Fix Spell Casting Proficiencies not progressing when casting most spells."

Purpose of change

I noticed at the end of my most recent run my character had not progressed in almost any spell proficiencies. Despite being a spell caster character who had cast many a spell. And kill a few thousands monsters. So I looked into it and it turns out due to some funkiness with how extra spell effects work, most spells don't actually increase your proficiency when cast.

Describe the solution

Apply the self hit flag to all extra effects associated with increasing the spell casters proficiency. This then allows all spells to improve your respective proficiencies.

Along the way I also fixed a few spells that had proficiency bonuses setup but lacked the extra effect to actually progress your proficiency.

Describe alternatives you've considered

I wrote up MD file that kind of explains how spell casting proficiencies work to my limited understanding of their implementation. And how to utilize them in spells people make. But it's not quite ready and I don't know when I will be happy with it. And I also really don't want to deal with trying to find out how to properly format it because I just know the tests are going to scream at until it's just the way they like it.

I did notice while I was working that the Vortex spell in the void mage attunement class doesn't actually use proficiencies. It might be the only player spell in Magicylsm that hasn't been converted yet. It didn't have any bonuses setup so I just left it alone. But I did consider fixing it.

Testing

I tried out a random smattering of spells to verify proficiency was actually going up when cast. I am absolutely not going to test all of them but the change is pretty minor so I am confident it all works.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Magiclysm Anything to do with the Magiclysm mod Mechanics: Enchantments / Spells Enchantments and spells labels Jun 26, 2024
@github-actions github-actions bot requested a review from KorGgenT June 26, 2024 17:56
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jun 26, 2024
@Maleclypse Maleclypse merged commit 7d0afa4 into CleverRaven:master Jun 27, 2024
23 of 26 checks passed
@QuillInkwell QuillInkwell deleted the magic_fix_spell_profs branch June 27, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mechanics: Enchantments / Spells Enchantments and spells Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants