[Magiclysm] Fix Spell Casting Proficiencies not progressing #74798
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mods "[Magicylsm] Fix Spell Casting Proficiencies not progressing when casting most spells."
Purpose of change
I noticed at the end of my most recent run my character had not progressed in almost any spell proficiencies. Despite being a spell caster character who had cast many a spell. And kill a few thousands monsters. So I looked into it and it turns out due to some funkiness with how extra spell effects work, most spells don't actually increase your proficiency when cast.
Describe the solution
Apply the self hit flag to all extra effects associated with increasing the spell casters proficiency. This then allows all spells to improve your respective proficiencies.
Along the way I also fixed a few spells that had proficiency bonuses setup but lacked the extra effect to actually progress your proficiency.
Describe alternatives you've considered
I wrote up MD file that kind of explains how spell casting proficiencies work to my limited understanding of their implementation. And how to utilize them in spells people make. But it's not quite ready and I don't know when I will be happy with it. And I also really don't want to deal with trying to find out how to properly format it because I just know the tests are going to scream at until it's just the way they like it.
I did notice while I was working that the Vortex spell in the void mage attunement class doesn't actually use proficiencies. It might be the only player spell in Magicylsm that hasn't been converted yet. It didn't have any bonuses setup so I just left it alone. But I did consider fixing it.
Testing
I tried out a random smattering of spells to verify proficiency was actually going up when cast. I am absolutely not going to test all of them but the change is pretty minor so I am confident it all works.
Additional context