Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct some remnants of nonfunctional extend/delete syntax #74768

Merged
merged 4 commits into from
Jun 25, 2024
Merged

Correct some remnants of nonfunctional extend/delete syntax #74768

merged 4 commits into from
Jun 25, 2024

Conversation

Karol1223
Copy link
Contributor

@Karol1223 Karol1223 commented Jun 24, 2024 •
edited
Loading

Summary

None

Purpose of change

I just want the broken syntax gone already before someone starts cargoculting this shit again

Describe the solution

  • Remove all broken and nonfunctional cases of delete in vanilla (that I found), replaced them with working alternatives where applicable
  • Remove the nonfunctional extend syntax for the fried pickled veggy definition. Didn't replace it with a working alternative because since this is a player craft it really doesn't matter
  • Correct the syntax for the delete for yule cat cub in Magiclysm
  • Simplify the Innawood aphid definition to the bare minimum to ease the maintenance burden, while also getting rid of its broken delete syntax

Describe alternatives you've considered

Testing

Additional context

@Karol1223 Karol1223 marked this pull request as ready for review June 24, 2024 19:27
@Karol1223 Karol1223 changed the title Correct the last remnants of nonfunctional extend/delete syntax Correct some remnants of nonfunctional extend/delete syntax Jun 24, 2024
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Magiclysm Anything to do with the Magiclysm mod Mods: Innawood 🌲 Anything to do with Innawood mod astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jun 24, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jun 25, 2024
@Maleclypse Maleclypse merged commit 50f8ab2 into CleverRaven:master Jun 25, 2024
21 of 25 checks passed
@Karol1223 Karol1223 deleted the idk branch June 25, 2024 16:16
@Karol1223 Karol1223 added the Monsters Monsters both friendly and unfriendly. label Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Innawood 🌲 Anything to do with Innawood mod Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding Monsters Monsters both friendly and unfriendly.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Karol1223 @Maleclypse