-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vitamin-based allergy #74763
Merged
Merged
Vitamin-based allergy #74763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: RenechCDDA <[email protected]>
github-actions
bot
added
[JSON]
Changes (can be) made in JSON
Items: Food / Vitamins
Comestibles and drinks
Code: Tests
Measurement, self-control, statistics, balancing.
[C++]
Changes (can be) made in C++. Previously named `Code`
Mods: Magiclysm
Anything to do with the Magiclysm mod
Mods: Aftershock
Anything to do with the Aftershock mod
Mods: Dinomod
Anything to do with the Dinoclysm mod (DinoMod)
Mechanics: Enchantments / Spells
Enchantments and spells
Mods: TropiCataclysm 🌴
Having to do with the tropical region mod for DDA.
Mods: Tamable Wildlife
Mods: Xedra Evolved
Anything to do with Xedra Evolved
<Enhancement / Feature>
New features, or enhancements on existing
labels
Jun 24, 2024
github-actions
bot
added
astyled
astyled PR, label is assigned by github actions
json-styled
JSON lint passed, label assigned by github actions
labels
Jun 24, 2024
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Jun 25, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
[C++]
Changes (can be) made in C++. Previously named `Code`
Code: Tests
Measurement, self-control, statistics, balancing.
<Enhancement / Feature>
New features, or enhancements on existing
Items: Food / Vitamins
Comestibles and drinks
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Mechanics: Enchantments / Spells
Enchantments and spells
Mods: Aftershock
Anything to do with the Aftershock mod
Mods: Dinomod
Anything to do with the Dinoclysm mod (DinoMod)
Mods: Magiclysm
Anything to do with the Magiclysm mod
Mods: Tamable Wildlife
Mods: TropiCataclysm 🌴
Having to do with the tropical region mod for DDA.
Mods: Xedra Evolved
Anything to do with Xedra Evolved
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Features "Food can inherit the allergens of materials it was cooked from"
Purpose of change
Continuation of #72224
Makes allergy a bit more robust - before the only way to assign allergy was giving a specific material to a food, which is both unflexible, do not allow to use the properties of ingredients, and created stuff like "wheat-free bread" as a separate item
Describe the solution
With the power of code, json, Harakka and Renech, fix it:
components
field in itemgroups to, for example, spawn bread and wheat-free bread dynamically, instead of deluxe_cheeseburger_wheat_free existing in a single form, having no recipe, not used anywhere, abandonedTesting
Took baklava, and removed it's
material
andvitamins
fields, then debug spawned, gave the character grain intolerance, and cooked out of three flours, in order:debug spawned, no vitamins
cooked out of flour
cooked out of wheat-free flour
cooked out of bread flour
walked around the city, food spawned looks good