Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added roof to two shacks #74758

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Conversation

PatrikLundell
Copy link
Contributor

Summary

None

Purpose of change

Add explicit roofs to two shacks in farm_nested.json (one of which is used only in trails, bizarrely enough).

Describe the solution

Add roof chunks and nest them from their respective building chunks.

Describe alternatives you've considered

Testing

  • Debug spawn horse farms until a greenhouse is generated, teleport to the greenhouse, and examine it.
  • Debug spawn fire lookout towers, teleport to their adjacent trail part, examine the part, and repeat until the shed is generated.
    Screenshot (586)
    Screenshot (587)
    Screenshot (588)
    Screenshot (589)

Additional context

Getting the smaller shed to generate wasn't trivial. The fire lookout generates it, fortunately, and we all know the trail connects fire lookout towers to farms...

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display labels Jun 24, 2024
@LovamKicsiGazsii
Copy link
Contributor

It's so cool that nested mapgen can span multiple levels now.

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jun 24, 2024
@PatrikLundell
Copy link
Contributor Author

We're having some teething problems with the 3D support, but it seems manageable.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jun 24, 2024
@Maleclypse Maleclypse merged commit 7da20bc into CleverRaven:master Jun 24, 2024
22 of 26 checks passed
@PatrikLundell PatrikLundell deleted the farm_nested branch June 24, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants