Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added roofs to greenhouses #74750

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Conversation

PatrikLundell
Copy link
Contributor

@PatrikLundell PatrikLundell commented Jun 24, 2024

Summary

None

Purpose of change

Add roofs to greenhouses.

Describe the solution

Add nested roof chunk to greenhouses.
Adjusted chicken coop to explicitly not have roofs, as there's nothing to support any roof.

Describe alternatives you've considered

  • Deal with churches using natural stone floors.
  • Rework chicken coop to have roof, e.g. by providing corner supports.
  • Remove pigeons from coop since they'll just fly away (and still would if roofs were added, since they can fly over the fences).

Testing

Changed the odds for greenhouses to show up in buildings using these chunks and verified they did show up with roofs. Made sure the three variants did appear correctly, but did only verify at least one of them appeared on each of the buildings using them (and showed up correctly).
Checked that the chicken coop looked OK in one using location.
The two first greenhouse variants on the cathedral (with it natural stone floor roof):
Screenshot (562)
Screenshot (563)
The third variant (note that the garden to the left isn't supposed to have a roof):
Screenshot (564)
Screenshot (565)
And the chicken coop (no image of the non existent roof, since it doesn't exist):
Screenshot (566)

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jun 24, 2024
@Maleclypse Maleclypse merged commit 3a3169f into CleverRaven:master Jun 24, 2024
24 of 28 checks passed
@PatrikLundell PatrikLundell deleted the nested_chunk branch June 24, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants