Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in gun variant validator script #74727

Merged

Conversation

anothersimulacrum
Copy link
Member

Summary

None

Purpose of change

GuardianDll: ERROR: Guns colt_anaconda_8 and colt_anaconda_6 are too similar and should be combined
GuardianDll: doc: "the barrel lengths of the guns are within 2 cm"
GuardianDll: "barrel_length": "203 mm" vs "barrel_length": "153 mm"
GuardianDll: what lies? documentation, script, or common sense?
anothersimulacrum: { 'id': 'colt_anaconda_8', 'ranged_damage': -17, 'ammo': ['44'], 'volume': 1384, 'weight': 1672, 'longest_side': 350, 'dispersion': 280, 'modes': [1], 'magazines': [6], 'speedloaders': ['44_speedloader6']}
anothersimulacrum: { 'id': 'colt_anaconda_6', 'ranged_damage': -17, 'ammo': ['44'], 'volume': 1299, 'weight': 1499, 'longest_side': 300, 'dispersion': 280, 'modes': [1], 'magazines': [6], 'speedloaders': ['44_speedloader6']}
anothersimulacrum: barrel_length isn't in the scraped JSON for whatever reason

Oops.

Describe the solution

Ensure all keys are preserved for checks.

Testing

Fetch #74719 and tools/json_tools/gun_variant_validator.py -v -cin data/json exits with code 0.

Additional context

Why were there two places keys were defined? The world wonders.
@github-actions github-actions bot added Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves [Python] Code made in Python Code: Tooling Tooling that is not part of the main game but is part of the repo. json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jun 23, 2024
@Maleclypse Maleclypse merged commit f9888e2 into CleverRaven:master Jun 23, 2024
17 of 22 checks passed
@anothersimulacrum anothersimulacrum deleted the fix-gun-variant-check branch June 23, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Tooling Tooling that is not part of the main game but is part of the repo. Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves json-styled JSON lint passed, label assigned by github actions [Python] Code made in Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants