Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the Rossi Gallery #74724

Merged
merged 8 commits into from
Jun 23, 2024
Merged

Adds the Rossi Gallery #74724

merged 8 commits into from
Jun 23, 2024

Conversation

Holli-Git
Copy link
Contributor

@Holli-Git Holli-Git commented Jun 22, 2024

Summary

Content "Adds pump action rifle"

Purpose of change

The Rossi Gallery is a funky lil .22 LR pump action, and it'd be nice to have more .22 rifles.
image

Describe the solution

Adds it, along with its predecessor the 1890 to DDotD.

Describe alternatives you've considered

Not doing this.

Testing

Here it is spawning in the world
image
And here it is as it exists in DDotD
image

Additional context

N/A

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Spawn Creatures, items, vehicles, locations appearing on map Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Mods: Generic Guns Anything to do with Generic Guns Mods: Dark Days of the Dead Anything related to the DDotD mod (classic style zombies) labels Jun 22, 2024
@github-actions github-actions bot requested a review from I-am-Erk June 22, 2024 18:02
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jun 22, 2024
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • A modern take on the Winchester 1890, the Rossi Gallery is a .22 LR rifle, notably using a pump action. Much like a pump action shotgun, the magazine tube is below it's 18 inch barrel and can hold 15 rounds. While pump actions are quite often associated with shotguns, the mechanism can be applied to rifles as well, though in practice it's limited to .22 LR.
  • Rossi Galleries
  • Rossi Gallery

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@github-actions github-actions bot added Code: Tests Measurement, self-control, statistics, balancing. BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jun 22, 2024
Copy link
Contributor

@DoctorBoomstick DoctorBoomstick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like to see some Rossi guns make there way into the mix.

data/json/items/gun/22.json Show resolved Hide resolved
data/json/items/gun/22.json Outdated Show resolved Hide resolved
data/json/items/gun/22.json Show resolved Hide resolved
data/json/items/gun/22.json Outdated Show resolved Hide resolved
data/json/items/gun/22.json Outdated Show resolved Hide resolved
Copy link
Contributor

@DoctorBoomstick DoctorBoomstick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A tentative suggestion, considering that mods are their own beast from vanilla, but I would posit that the same logic that included variant, non-branded guns in the main game also applies to mod guns such as this one, and those already present.

data/mods/classic_zombies/items/guns.json Show resolved Hide resolved
@Maleclypse Maleclypse merged commit 7c65121 into CleverRaven:master Jun 23, 2024
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Tests Measurement, self-control, statistics, balancing. Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Dark Days of the Dead Anything related to the DDotD mod (classic style zombies) Mods: Generic Guns Anything to do with Generic Guns Mods Issues related to mods or modding Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants