Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added roofs to FEMA 2 buildings #74718

Merged
merged 1 commit into from
Jun 22, 2024
Merged

Conversation

PatrikLundell
Copy link
Contributor

Summary

None

Purpose of change

Add roofs to the buildings in the FEMA 2 camp without relying on add_roofs magic (which doesn't do tents anyway).

Describe the solution

Add a roof nest for each tile version that needed one and then nest it into said tile.

Describe alternatives you've considered

  • Add roof decorations.
  • Add solar panels on the real roofs to make it worth visiting this horrid place.
  • Restructure the mess into a single file.
  • Restructure the mess so the tiles don't have to be rotated.
  • Restructure the mess to a similar structure as the first FEMA camp uses.

Testing

Spawn a FEMA camp 2, teleport to it, inspect it.
Repeat the above 9 more times to get a decent chance of covering all variants.

This is number 5, with no particular reason for selecting that particular instance over any other:
Screenshot (550)
Screenshot (551)
Screenshot (552)
Screenshot (553)

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jun 22, 2024
@Maleclypse Maleclypse merged commit 32d74af into CleverRaven:master Jun 22, 2024
22 of 26 checks passed
@PatrikLundell PatrikLundell deleted the fema_2 branch June 23, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants