Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove AF-2011A1 #74713

Merged
merged 2 commits into from
Jun 22, 2024
Merged

Remove AF-2011A1 #74713

merged 2 commits into from
Jun 22, 2024

Conversation

Holli-Git
Copy link
Contributor

Summary

Bugfixes "Removes AF-2011A1"

Purpose of change

Doesn't fit criteria for inclusion, and by a very large margin.
image

Describe the solution

Removes it.

Describe alternatives you've considered

Making it 45 ACP, and then removing it.

Testing

Before change:
image
After change:
image
This is to show nothing breaks when you load into a save with the item in existence.

Additional context

Hopefully this should be the last gun removal PR before I move onto actually adding guns. This whole time I wanted to add guns but I kept getting distracted by silly guns.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Magazines Ammo holding items and objects. Spawn Creatures, items, vehicles, locations appearing on map Code: Tests Measurement, self-control, statistics, balancing. Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves [Python] Code made in Python Mods: Generic Guns Anything to do with Generic Guns Mods: Dark Days of the Dead Anything related to the DDotD mod (classic style zombies) Code: Tooling Tooling that is not part of the main game but is part of the repo. <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jun 22, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jun 22, 2024
@Kantonine
Copy link
Contributor

Nooooo not the funni 1911! /jk

hopefully the newer selection will be more than enough!

@kevingranade kevingranade merged commit b7a356d into CleverRaven:master Jun 22, 2024
20 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Code: Tests Measurement, self-control, statistics, balancing. Code: Tooling Tooling that is not part of the main game but is part of the repo. Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Items: Magazines Ammo holding items and objects. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Dark Days of the Dead Anything related to the DDotD mod (classic style zombies) Mods: Generic Guns Anything to do with Generic Guns [Python] Code made in Python Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Holli-Git @Kantonine @kevingranade