Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a teeth necklace #74692

Merged
merged 7 commits into from
Jun 24, 2024
Merged

Conversation

BalthazarArgall
Copy link
Contributor

@BalthazarArgall BalthazarArgall commented Jun 20, 2024

Summary

Content "Add a teeth necklace"

Purpose of change

Teeth necklaces are a classic traditional jewelry yet we don't have them in the game.

Describe the solution

Add a teeth necklace to the game. Along with a recipe.

Describe alternatives you've considered

  • Use conditional names/snippets. I preferred to use variants so descriptions can be added for different types of teeth in the future, which is cool.
  • Make the item more complex, with armor parts for example. The item is mostly cosmetic so I decided make it as simple as possible, with almost no gameplay impact.
  • Make another nest for "bone jewelry". May become relevant in the future if I, or someone else, add more bone jewelry but right now this is not needed.
  • Add the item to spawn groups. Impossible due to the fact that the only version is made from monster teeth at the moment which is exclusively a post Cataclysm thing, how convenient. Will have to be a thing if shark teeth and necklaces are added in the future.

Testing

Spawned it, wore it, no issue.

Additional context

Image for context of recipe and general concept, even if isn't specifically a shark teeth I'm adding (couldn't find a nether monster tooth necklace image):
dsc09687-ezgif com-webp-to-jpg-converter

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Armor / Clothing Armor and clothing json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jun 20, 2024
Copy link
Contributor

@DoctorBoomstick DoctorBoomstick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks cool. The teeth item looks a little strange, considering it’s so tiny despite coming from the maw of a literal alien monster bigger than an in-game skyscraper, and it's referenced as “teeth” despite the fact that I can only assume the character is wielding one at a time, but these issues are not the PR’s problem.

data/json/items/armor/jewelry.json Outdated Show resolved Hide resolved
data/json/recipes/armor/jewelry.json Show resolved Hide resolved
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jun 20, 2024
@Karol1223
Copy link
Contributor

There really is 0 reasoning to add a recipe nest for something with just a single recipe in it. The nests can be added if/when you add more versions of this.

@BalthazarArgall
Copy link
Contributor Author

There really is 0 reasoning to add a recipe nest for something with just a single recipe in it. The nests can be added if/when you add more versions of this.

Sure.

@Maleclypse Maleclypse merged commit 1b599f0 into CleverRaven:master Jun 24, 2024
21 of 24 checks passed
@BalthazarArgall BalthazarArgall deleted the TeethNecklace branch June 28, 2024 15:22
@BalthazarArgall BalthazarArgall restored the TeethNecklace branch June 28, 2024 15:22
@BalthazarArgall BalthazarArgall deleted the TeethNecklace branch June 28, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants