Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous Clothing Disassembly’s: 2 #74675

Merged
merged 59 commits into from
Jun 25, 2024

Conversation

DoctorBoomstick
Copy link
Contributor

@DoctorBoomstick DoctorBoomstick commented Jun 19, 2024

Summary

None

Purpose of change

In the wake of playing, I discovered some items that either had no deconstruct recipes or had suspect results. This broke my immersion. I, now, unbreak my immersion: round 2.

Describe the solution

I have:

  • Added a deconstruct recipe for the tactical jacket.
  • Added a deconstruct recipe for the army jacket.
  • Added a deconstruct recipe for the tactical pants.
  • Added a deconstruct recipe for the cowboy hat.
  • Added a deconstruct recipe for the gas mask pouch. As part of this, I added a new spare parts item, the fabric strap, which has been added to suitable craft requirement groups.

Describe alternatives you've considered

Testing

Additional context

Consult #74659 for part one of this crusade.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Armor / Clothing Armor and clothing astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jun 19, 2024
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • A strip of broad, flat cotton, 42 inches in length, with a metal adjustment buckle threaded in the centre. Normally used as a shoulder strap for bags, its ends are usually sown about a corresponding container's D-rings.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

data/json/uncraft/armor/torso.json Outdated Show resolved Hide resolved
data/json/uncraft/armor/torso.json Outdated Show resolved Hide resolved
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jun 24, 2024
@Maleclypse Maleclypse merged commit f0d983a into CleverRaven:master Jun 25, 2024
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants