Moving quadrupedally through certain traps now applies appropriate damage to arms/hands

[GalacticApple]

Summary

Bugfixes "Updates trapfunc.cpp to consider quadrupedal movement"

Purpose of change

This is something of a follow-up to #74639. I realized that certain traps, namely lava, goo pits, caltrops and bear traps don't damage your arms/hands when moving through them quadrupedally. I also noticed that there's a "quadruped_half" effect which was meant to be for when you only have Paws and Digitigrade, so I updated enchantments.json to make use of it.

Describe the solution

I updated the functions in trapfunc.cpp to consider if a character has either the quadruped_full or quadruped_half effects. I also updated the functions changed in #74639 to consider quadruped_half.

As an example, beartraps can now snag your arm if you move over them on all-fours.

Describe alternatives you've considered

I may or may not come across other situations where you should hurt your hands when moving like that.

Testing

Compiled and tested on my personal copy of CDDA.

Additional context

[anothersimulacrum]

@Venera3 Do you have any advice on how to have this use less hardcoded bodypart id checks?

[Venera3]

Well.
The proper way to do this is to jetisson the whole enchantment into effect into hardcoded effect check jank and just move it to a new movement mode. For that you'd need to add a way for traits to add movement modes and a ground_contact list to movemodes (they are thankfully unhardcoded otherwise so it's a smaller undertaking than it sounds), then reroute the checks to hurt the ground contact of your current movemode.

Otherwise you're stuck with the ugly if you have the effect hurt all your hands and feet solution with get_all_bodyparts_of_type (or similar, I'm not sure what the function is called).

I'd be thankful if you took the high road and tackled the first solution but I'm not gonna be a stick in the mud if you go with the second if that's too much.

[GalacticApple]

I think tackling the former would be a future pull request for me.

Also, wouldn't the former require a total rework of how traps apply damage? Each trap pretty much applies damage in a unique way.

[Venera3]

Unhardcoding traps is long overdue, but having a common target bp selector is preferable to twelve counts of hardcoded effect checks into hardcoded bp assignments even without that.

[anothersimulacrum]

You should make a function, something like std::vector<bodypart_id> Creature::get_ground_contact_bodyparts() const, which does this effect check, and returns the appropriate bodyparts.

This would use Creature::get_all_body_parts_of_type to return either foot body parts or foot and hand body parts, depending on the result of the effect check.

This would then replace everywhere here that you are manually specifying bodypart ids.

[anothersimulacrum]

Looks great!

[GalacticApple]

Do I need it to pass all the checks?

[anothersimulacrum]

Only the required checks. If it fails the others and it's not the fault of this PR, it's okay.