Doggo JSON cleanup #74645
Merged
Doggo JSON cleanup #74645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each breed of dog had their flags duplicated instead of extending or deleting the unused flags from the base monster.
Updated all of the puppies to copy from the base mon_dog_pup so I could rip all the duplicated entries out.
Petfood was defined on every adult dog, oof. Also went through and removed eat_food specials that were duplicated and combed through the chihuahuas. :3
github-actions
bot
added
[JSON]
Karol1223
requested changes
Jun 18, 2024
In addition to applying the suggestions Karol sent, I made the executive decision that all dogs are decent in packs and retain the SWARMS and GROUP_MORALE flags. Dogs almost always spawn in small packs so it makes sense for them to have more pack mentality reflected in their definitions.
In addition to applying the suggestions Karol sent, I made the executive decision that all dogs are decent in packs and retain the SWARMS and GROUP_MORALE flags. Dogs almost always spawn in small packs so it makes sense for them to have more pack mentality reflected in their definitions. Co-Authored-By: Karol1223 <[email protected]>
|
Feel free to include 'Fixes #62019' in your PR description for a free serotonin boost |
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Definitions for each breed of dog contained many duplicated entries and none of the puppies were using copy-from despite having lots of overlapping information. This was causing issues with a feature I was toying with as each dog was overwriting their flags instead of using "extend" or "delete".
Describe the solution
Add copy-from fields to each puppy type and removed duplicate entries in each dog breed.
Describe alternatives you've considered
Modifying each dog breed with the desired flags, but no thank you. That sounds like pain.
Testing
Spawned several dogs and tested that they could still be tamed and butchered into the right harvests. I tried it with labrador mutt, german shepard, plus the beagle and everything seemed to work smoothly with no changes.
After the changes to the "zombifies-into" field I tested killing a few of the puppy breeds and confirmed that they do not revive into zombie dogs as was intended. As per Karol's suggestion, this fixes #62019
Additional context