Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added roof to speedway speaker roof access shack #74629

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

PatrikLundell
Copy link
Contributor

Summary

None

Purpose of change

Ensuring all roofs are explicit: speedway.

Describe the solution

Add new JSON layer and hook it into the infrastructure.

Describe alternatives you've considered

Testing

Debug spawn facility, teleport to it, inspect it.
Screenshot (507)
Screenshot (508)

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jun 17, 2024
@RenechCDDA
Copy link
Member

Thank you for doing all this work on the roofs. I know it can feel thankless, but these are chores that are really appreciated.

@PatrikLundell
Copy link
Contributor Author

At least I have an end goal in the form of 3D mapgen and removal of the damages caused by add_roofs to look forward to.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jun 17, 2024
@dseguin dseguin merged commit e02b206 into CleverRaven:master Jun 17, 2024
20 of 26 checks passed
@PatrikLundell PatrikLundell deleted the speedway branch June 17, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants