Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added roofs onto gun store roof access shacks #74625

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

PatrikLundell
Copy link
Contributor

Summary

None

Purpose of change

Add explicit roofs on gun store roof access shacks, removing reliance on add_roofs magic.

Describe the solution

Define two new JSON layers and hook them into the infrastructure for the regular and looted store variants.

Describe alternatives you've considered

Testing

Debug spawn each store, teleport to it, and examine it.
Screenshot (492)
Screenshot (493)
Screenshot (494)
Screenshot (495)
Screenshot (496)
Screenshot (497)
Screenshot (498)
Screenshot (499)

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jun 17, 2024
@dseguin dseguin merged commit 6a6567c into CleverRaven:master Jun 17, 2024
22 of 26 checks passed
@PatrikLundell PatrikLundell deleted the s_gun branch June 17, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants