Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding tiny bottles and modifying nicotine liquid bottles #74614

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

bleaky
Copy link
Contributor

@bleaky bleaky commented Jun 17, 2024

Summary

Content "nicotine liquid alteration"

Purpose of change

I had noticed that nicotine bottles were 250ml and also held that much liquid. this is a colossal amount of fluid for this particular task. in life, they tend to use a standardized 30ml eyedropper style bottle, and so i've added that bottle, and i've adjusted the count such that it's now 1 charge per smoke sesh. i've also changed the weight of it, because previously it was about twice as dense as water, now it's as dense as, which also matches with the specific gravity of propylene glycol.

Describe the solution

it simply adds an item, calls to that item, and also changes the nicotine liquid values themselves to reflect the changes

Describe alternatives you've considered

the only possibly considerations i had were bottle sizes. i looked for eye dropper bottles but didn't find any which i found a little surprising, so i figured making my own would be good.

Testing

rolled a random character, spawned in an advanced e-cig, spawned in an ultra-light battery, spawned in some nicotine liquid bottles. i examined everything and tried smoking to make sure the charge count was correct. everything looks okay.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves new contributor labels Jun 17, 2024
@github-actions github-actions bot added Items: Containers Things that hold other things json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jun 17, 2024
@Maleclypse Maleclypse merged commit 1e1ac5e into CleverRaven:master Jun 18, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Items: Containers Things that hold other things [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions new contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants