Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove FS2000, Colt Lightning #74610

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Remove FS2000, Colt Lightning #74610

merged 2 commits into from
Jun 18, 2024

Conversation

Holli-Git
Copy link
Contributor

@Holli-Git Holli-Git commented Jun 16, 2024 •
edited
Loading

Summary

Bugfixes "Removes FS2K, Colt Lightning"

Purpose of change

Both of these guns have <100 hits on gunbroker.
image
image
Funnily enough gunbroker has 0 actual colt lightnings in 45 Colt, the results are just R92s and .22 LR colt lightnings.

Describe the solution

Migrates the FS2K and its gunmod into the RDB and forward grip respectively, and moves the CL into the obsoletion folder.

Describe alternatives you've considered

Not doing this.

Testing

Before:
image
After:
image

Additional context

I kept the migration part in GG for the colt lightning, I have a gun PR in the works for some lever actions in .45 Colt and 357/38

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Spawn Creatures, items, vehicles, locations appearing on map Code: Tests Measurement, self-control, statistics, balancing. Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves [Python] Code made in Python Mods: Generic Guns Anything to do with Generic Guns Mods: Dark Days of the Dead Anything related to the DDotD mod (classic style zombies) Code: Tooling Tooling that is not part of the main game but is part of the repo. <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jun 16, 2024
@github-actions github-actions bot added Items: Gunmod / Toolmod Weapon and tool attachments, and add-ons BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jun 16, 2024
@Maleclypse Maleclypse merged commit 2f7458e into CleverRaven:master Jun 18, 2024
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Code: Tests Measurement, self-control, statistics, balancing. Code: Tooling Tooling that is not part of the main game but is part of the repo. Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Items: Gunmod / Toolmod Weapon and tool attachments, and add-ons [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Dark Days of the Dead Anything related to the DDotD mod (classic style zombies) Mods: Generic Guns Anything to do with Generic Guns [Python] Code made in Python Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Holli-Git @Maleclypse