Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop object creator builds from CI #74587

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

harakka
Copy link
Member

@harakka harakka commented Jun 16, 2024

Summary

Build "No longer build object creator in CI nor include it in releases"

Purpose of change

Free up CI resources and allow builds to show up on cataclysmdda.org releases page sans object creator.

Fixes #74562

Currently object creator builds fail again and the release workflow doesn't update gh-pages if it doesn't run succesfully.
Building object creator and adding it to releases was done 9 months ago so that people would have a chance to test it out and maybe get someone to develop it again. This has not worked out. The tool only allows fiddling with spells and item groups, both of which need user knowledge to hook them up to rest of the game json, so utility is limited. On the devcord, I haven't seen anyone ever comment on using it. I have seen comments that it has apparently been crashing on start on Windows for a long time but no-one much has noticed.

Describe the solution

Remove object creator from CI. I tried to follow the previous PRs through which added this into CI or changed something about how object creator is built in CI, hopefully I didn't miss anything.

The code is left in repo as dead code as courtesy to KorGgenT https://discord.com/channels/598523535169945603/598535827169083403/1251656064156565565 even though I'd prefer to remove it too, since it has some maintenance burden due to coming up in searches etc. This should really be some kind of sister project IMO by someone who actively works on it.

Describe alternatives you've considered

Testing

Running the release build on my own repo to see the expected release artifacts generate and the experimental release workflow gets the right status. (don't mind the commit msg on that run, had to throw in a few extra commits to get the android builds to finish).

Additional context

@github-actions github-actions bot added the Code: Tooling Tooling that is not part of the main game but is part of the repo. label Jun 16, 2024
@harakka harakka marked this pull request as draft June 16, 2024 10:06
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jun 16, 2024
@harakka harakka marked this pull request as ready for review June 16, 2024 13:34
@harakka harakka requested a review from akrieger June 16, 2024 13:34
@harakka
Copy link
Member Author

harakka commented Jun 16, 2024

@akrieger or anyone else who is clued in on the Windows build side, can you check that this is ok and I'm not missing anything critical. I also saw that some previous cache sizes were chosen based on object creator being built, I don't know if those need to be fiddled with because of this.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jun 16, 2024
@Procyonae
Copy link
Contributor

Presumably fixes #74562?

@akrieger
Copy link
Member

I'm fine dropping it, and this seems correct, but FTR what's broken is the appcontainer build, the native windows build is fine (https://github.com/CleverRaven/Cataclysm-DDA/actions/runs/9557490756/job/26344654164#step:15:2636). IDK why we're trying to crossbuild object creator through this indirect vm based mechanism (I guess to exercise that appcontainers do work?) instead of releasing the msvc built version. But as noted, no one active is owning it, it should be laid to rest until someone does.

@akrieger akrieger merged commit 008277f into CleverRaven:master Jun 18, 2024
37 of 45 checks passed
@harakka harakka deleted the drop_object_creator_from_ci branch July 31, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Tooling Tooling that is not part of the main game but is part of the repo. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems w/ the website.
3 participants