Drop object creator builds from CI #74587
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Build "No longer build object creator in CI nor include it in releases"
Purpose of change
Free up CI resources and allow builds to show up on cataclysmdda.org releases page sans object creator.
Fixes #74562
Currently object creator builds fail again and the release workflow doesn't update gh-pages if it doesn't run succesfully.
Building object creator and adding it to releases was done 9 months ago so that people would have a chance to test it out and maybe get someone to develop it again. This has not worked out. The tool only allows fiddling with spells and item groups, both of which need user knowledge to hook them up to rest of the game json, so utility is limited. On the devcord, I haven't seen anyone ever comment on using it. I have seen comments that it has apparently been crashing on start on Windows for a long time but no-one much has noticed.
Describe the solution
Remove object creator from CI. I tried to follow the previous PRs through which added this into CI or changed something about how object creator is built in CI, hopefully I didn't miss anything.
The code is left in repo as dead code as courtesy to KorGgenT https://discord.com/channels/598523535169945603/598535827169083403/1251656064156565565 even though I'd prefer to remove it too, since it has some maintenance burden due to coming up in searches etc. This should really be some kind of sister project IMO by someone who actively works on it.
Describe alternatives you've considered
Testing
Running the release build on my own repo to see the expected release artifacts generate and the experimental release workflow gets the right status. (don't mind the commit msg on that run, had to throw in a few extra commits to get the android builds to finish).
Additional context