Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Chiappa Rhino #74561

Merged
merged 11 commits into from
Jun 18, 2024
Merged

Conversation

BalthazarArgall
Copy link
Contributor

@BalthazarArgall BalthazarArgall commented Jun 15, 2024

Summary

Content "Add the Chiappa Rhino"

Purpose of change

The Chiappa Rhino technically meets the standards for inclusion but isn't in the game despite being the most awesomest looking revolver after the Mateba Unica.

Describe the solution

The most common version of the Rhino is the 60DS in .357 so this is the version that will be added to the game. The technical specs for this version have been retrieved and implemented as faithfully as possible.

The spawn rates have been based off the ones for the Manurhin (mr73).

Describe alternatives you've considered

Testing

Spawned the gun, wielded it.

Additional context

Screen of the gunbroker search: (Apparently I'm supposed to include closed sales but I don't know how can't because I live in Europe)
Untitled
Image of the item for context:
ADP760

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Spawn Creatures, items, vehicles, locations appearing on map Code: Tests Measurement, self-control, statistics, balancing. Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Mods: Generic Guns Anything to do with Generic Guns json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jun 15, 2024
@Kantonine
Copy link
Contributor

Hmmm, this might seem a stretch, but how common is the 9x19mm version, is it comparably common to the .357, or is it too nice to be able to pass the inclusion standard?

@Kantonine
Copy link
Contributor

oh, and another point, would it be easily implementable to have a multi length barrel system for these? I.e. have a barrel mod that adds additional length onto the barrel, or would that mean having the basic gun have 0 barrel length, and the mod being bore based like the MDRX system?

@BalthazarArgall
Copy link
Contributor Author

Hmmm, this might seem a stretch, but how common is the 9x19mm version, is it comparably common to the .357, or is it too nice to be able to pass the inclusion standard?

The 9x19 version is rarer than the .38, I cannot make a "proper" gunbroker search but if you can find >100 hits for a 9x19 version I'd be happy to implement it.

oh, and another point, would it be easily implementable to have a multi length barrel system for these? I.e. have a barrel mod that adds additional length onto the barrel, or would that mean having the basic gun have 0 barrel length, and the mod being bore based like the MDRX system?

Nope, Rhinos don't officially support changing the length of the barrel. There may be a way to do this as a gunsmith but I'd need proof before I make it possible.

@Kantonine
Copy link
Contributor

That's perfectly understandable! Maybe just have a reg size and then a snubbie version? As for the Gunbroker search, me being the UK means doing that wouldn't be exactly advisable

@BalthazarArgall
Copy link
Contributor Author

That's perfectly understandable! Maybe just have a reg size and then a snubbie version? As for the Gunbroker search, me being the UK means doing that wouldn't be exactly advisable

Well, I'm implementing it like this for the time being, if you find a way to prove that there's a significant number of 9x19 Rhinos out there in New England hit me up and I'll implement the version myself, and I do mean it.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jun 16, 2024
@BalthazarArgall BalthazarArgall marked this pull request as ready for review June 16, 2024 15:25
@BalthazarArgall BalthazarArgall marked this pull request as draft June 16, 2024 16:39
@BalthazarArgall BalthazarArgall marked this pull request as ready for review June 16, 2024 18:13
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • An innovative, futuristic looking revolver designed by Emilio Ghisoni after developing the Mateba, its most distinctive feature is its barrel, aligned with the bottom chamber of its hexagonal cylinder to alleviate muzzle flip.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@BalthazarArgall
Copy link
Contributor Author

BalthazarArgall commented Jun 17, 2024

Sorry for the back and forth, I was a bit confused with the generic naming and gun items architecture, but it should be fine now.

@Maleclypse Maleclypse merged commit 58aa130 into CleverRaven:master Jun 18, 2024
24 checks passed
@BalthazarArgall BalthazarArgall deleted the ChiappaRhino branch June 28, 2024 15:22
@BalthazarArgall BalthazarArgall restored the ChiappaRhino branch June 28, 2024 15:22
@BalthazarArgall BalthazarArgall deleted the ChiappaRhino branch June 28, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Tests Measurement, self-control, statistics, balancing. Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Generic Guns Anything to do with Generic Guns Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants