Start menu: Selector for trait variants #74525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anothersimulacrum
force-pushed
the
smaller-trait-menu
branch
from
baaf0ec to
8037a84
Compare
Would removing the one currently selected from the list and making the title "Change eye colour from ?" (with unselected being "random") be better? |
|
No. It may seem strange to unselect eye color, but this is also used for the hair styles, which should be unselectable. That could be worked around by selecting something if you have any of the variants removing it, and only selecting it without the trait bringing up this menu, but I think that's bad UX. |
github-actions
bot
added
Mutations / Traits / Professions/ Hobbies
dseguin
reviewed
Jun 15, 2024
github-actions
bot
added
the
BasicBuildPassed
anothersimulacrum
force-pushed
the
smaller-trait-menu
branch
from
8037a84 to
2835be4
Compare
Instead of listing all the trait variants individually, add a menu selector for the variants and display the "archetype" trait for them. This does some funky things with uilist, but this was the path of least resistance. It would be nice if uilist had a way to show a "selected" entry that wasn't the one the cursor was over.
anothersimulacrum
force-pushed
the
smaller-trait-menu
branch
from
2835be4 to
6412926
Compare
github-actions
bot
added
BasicBuildPassed
SurFlurer
added a commit
to SurFlurer/Cataclysm-DDA
that referenced
this pull request
Aug 26, 2024
This reverts commit a00f0e1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Interface "Add selection menu for cosmetic traits in character creation"
Purpose of change
Make the cosmetic traits list easier to navigate.
Describe the solution
Instead of listing all the trait variants individually, add a menu selector for the variants and display the "archetype" trait for them.
Describe alternatives you've considered
This does some funky things with uilist, but this was the path of least resistance. It would be nice if uilist had a way to show a "selected" entry that wasn't the one the cursor was over.
Testing
Additional context