Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit roof on garage version 2 #73957

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

PatrikLundell
Copy link
Contributor

@PatrikLundell PatrikLundell commented May 20, 2024

Summary

None

Purpose of change

Add explicit roof on garage expansion version 2 rather than relying on magic.

Describe the solution

Specified a single type of roof for the whole building since all of its floor is fixed. Thus, the common palette is extended with the shingle roof associated with dirt floors, and all roof sections are using this rather than a material dependent selection.

Describe alternatives you've considered

  • Leave the edges of the building to be material dependent.
  • Let the roof be material dependent.

Testing

  • Created a base save with a fresh bare bones camp (and a companion).
  • Built the whole garage from mi-go resin (easiest to use and material doesn't affect the roof).
  • Teleported up on the roof to inspect it, and found I'd screwed up one section.
  • Started from the save and started building the expansion again.
  • Suddenly the companion died after having decided it couldn't eat after returning from construction.
  • Spawned new companion and set it to work to continue construction.
  • The new companion also died in seemingly the same way.
  • Gave up as the failing section had been constructed, teleported up onto the roof and verified that section was now correct (and the two other sections constructed at the same time were correct as well).
  • Declared victory anyway.

The state of the partially constructed building in the second run. You have to believe me when I say the remainder had a shingle roof all over it as it should in the first run.
Screenshot (367)

Additional context

The two dead companions indicate there is something not working properly with eating and base camp tasks.
I don't really know what the difference between the two sessions was, though.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Crafting / Construction / Recipes Includes: Uncrafting / Disassembling json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels May 20, 2024
@Maleclypse Maleclypse merged commit e8905f8 into CleverRaven:master May 21, 2024
27 checks passed
@PatrikLundell PatrikLundell deleted the garage2 branch May 21, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants