Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant emscripten build #73693

Merged
merged 1 commit into from
May 12, 2024

Conversation

kevingranade
Copy link
Member

Summary

None

Purpose of change

Turns out this was a redundant build.

Describe the solution

Just remove it, we can maybe look at making it depend on the other builds or something but for releases it's less of a big deal than for PRs anyway.

Turns out this was already being built
@github-actions github-actions bot added Code: Tooling Tooling that is not part of the main game but is part of the repo. json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels May 12, 2024
@dseguin dseguin merged commit 39e2afa into master May 12, 2024
17 of 22 checks passed
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label May 12, 2024
nornagon pushed a commit to nornagon/Cataclysm-DDA that referenced this pull request Jun 7, 2024
Turns out this was already being built
@kevingranade kevingranade deleted the kevingranade-just-one-emscripten-thanks branch June 13, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Tooling Tooling that is not part of the main game but is part of the repo. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants