Build emscripten after matrix build. #73615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Code: Tooling
github-actions
bot
added
the
BasicBuildPassed
nornagon
pushed a commit
to nornagon/Cataclysm-DDA
that referenced
this pull request
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Build "Defer emscripten builds until after matrix builds succeed"
Purpose of change
Emscripten builds eat up our CI capacity. They run in parallel with the normal builds but take a long time and don't run useful tests. This capacity is wasted when tests fail faster.
Describe the solution
Run the emscripten build as the last step of the general build matrix using better github workflow sequencing.
Describe alternatives you've considered
Nada.
Testing
https://github.com/akrieger/Cataclysm-DDA/actions/runs/9022894191
Additional context