typified animation.cpp #73609
Merged
typified animation.cpp #73609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Code: Tests
github-actions
bot
added
json-styled
github-actions
bot
added
the
BasicBuildPassed
GuardianDll
added a commit
to GuardianDll/Cataclysm-DDA
that referenced
this pull request
May 15, 2024
Squashed commit: [795be74] TamableWildlife Skunk Friends (CleverRaven#73645) [b345d8e] Made a change to the popup to fix text being cut off at low resolutions. (CleverRaven#73678) [0a771f6] [Magiclysm] New joke spell (CleverRaven#73251) * Spell creation plus scroll plus addition to existing book plus spawn for scroll * Apply suggestions from code review Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: TheShadowFerret <[email protected]> * fix ellipsis * fix formatting error --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: TheShadowFerret <[email protected]> [9017632] Increase feral clairsentient dodge [0adfdf1] [MoM] Normalize feral biokinetic HP (CleverRaven#73635) * Fix HP * Fix HP [1a8080a] Added Bronze Wood Saw to Misc Repair Kit Craft (CleverRaven#73654) [59351db] #include vector in cata_imgui.h (CleverRaven#73681) [cabc0eb] style [e876fae] Provided 3D camp construction + Livestock 2 example [bc9c909] Use dummy parser for attack_vector to fix string extraction script error (CleverRaven#73659) [15c4984] typified animation.cpp (CleverRaven#73609) [548059a] test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Add position typing to a new set of code.
Describe the solution
Go through animation.cpp and replace generic (tri)points with typed ones.
Make associated follow on changes in related code, with some short circuiting to stop it from ballooning even further.
Note that there should be no functional change.
Describe alternatives you've considered
Try to understand what types more (tri)points are. There are "offset" parameters, for instance. I've left these untyped as I'm not sure what they represent.
Try to understand if cata_tiles and/or sdl_tiles actually are used to serve both the reality bubble ((tri)point_bub_ms for the most part) as well as some OMT coordinate system which may be relative to something or be absolute (to serve the overmap display), and, if that's the case, whether they ought to remain untyped or get dual operations for the operations that are used for both purposes.
Testing
Limited to loading a save, walk away with a bunch of companions in tow for a number of overmap and encounter some wildlife, teleport back, and climb the roof.
Additional context