Test to ensure unconditional and conditional nest placement works #73607
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Prevent a repeat of #67197
Describe the solution
The test checks each conditional placement method with both a condition that should resolve true and another that should resolve false, as well as an unconditional nest with an else_chunks for it's false test
Checks that om_terrain_match_type works in neighbors
Checks that if multiple conditions are used all must be true
Describe alternatives you've considered
Adding this sooner
Giving each nest an else_chunk with a false terrain so you have true/false/unplaced as opposed to placed/unplaced
Testing
Ran 550 times locally with no fails
(Running it 500 times on my not particularly powerful PC only took 27.88s, I love how fast code can be)
Additional context