-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Imgui iteminfo #73456
Imgui iteminfo #73456
Conversation
6862caa
to
3e1e202
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of small suggestions
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered. |
2ecf93c
to
65bf188
Compare
65bf188
to
b4474ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feels great! Just two tiny nits :)
b4474ba
to
9fce736
Compare
Summary
Interface "Add imgui version of the iteminfo window"
Purpose of change
Part of the migration to imgui UIs. I specifically need this for #55503, but it's standalone and used in many other places, too, so it gets a separate PR.
Describe the solution
Add an imgui version of iteminfo, both as a separate window and as separate controls available for embedding in already existing imgui windows.
Use the separate window for examining items in the inventory selector, AIM and crafting menu.
Still have to work out some issues.
execute
method.Describe alternatives you've considered
Going further with the migration of this, but I'm mainly doing this for #55503, and this does all I need for that plus some simple examples.
Testing
Examined items in the aforementioned menus.
Additional context
Other menus that display iteminfo, but that need proper migrations to use it:
V
menu to ImGui #55503)Examine in inventory:
Examine in crafting menu:
Examine in AIM:
(Examining worn/wielded items still uses the old version since it's different.)