AIM: when cannot wear, try to wield #73181
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Interface "AIM: when cannot wear, try to wield"
Purpose of change
Resolve #73121
Describe the solution
Describe alternatives you've considered
Make it a proper selectable destination. More code, less hacky ( => less bugs?), more things in AIM.
Testing
More testing should be done.Current testing is sufficient.source == dest
would probably need to be true for them to disappear (according to .h file)inRemoved occurrences by refactoringaction_move_item
squares[destarea]
is sometimes accessed. I think it should be undefined behaviour whendestarea = AIM_WIELD
, but didn't test it.bug: having no space to store and wearing a mattress asks to wield the mattress instead then fails with "Destination area is full. Remove some items first." It probably considers the free volume of the inventory. It shouldn't, it should wield the mattress.Fixed.Additional context
Demonstrating better flow of Wearing / Wielding:
Cataclysm_.Dark.Days.Ahead.-.0.G-8938-geb7c262356-dirty.2024-04-22.10-31-45.mp4