Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak spawns of hidden lab under retirement home #73154

Merged
merged 1 commit into from
Apr 21, 2024

Conversation

kevingranade
Copy link
Member

Summary

None

Purpose of change

I've been seeing failures to spawn and I suspect the (arbitrary) distance from spawn parameters are the problem.

Describe the solution

Allow it to spawn further from cities.
While I was at it added global uniqueness, there's no reason to have multiple of these.

Describe alternatives you've considered

Increased spawn chance might do it too, but it's already pretty high.

Testing

Just need multiple clean runs on the overnap_test

Additional context

Most recently seen here https://github.com/CleverRaven/Cataclysm-DDA/actions/runs/8710039326/job/23891043450?pr=73037

I've been seeing failures to spawn and I suspect the (arbitrary) distance from spawn parameters are the problem.
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Apr 20, 2024
@Maleclypse Maleclypse merged commit 82b4514 into master Apr 21, 2024
23 of 26 checks passed
@kevingranade kevingranade deleted the kevingranade-patch-1 branch April 24, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants