Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos and plurals #73065

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Fix typos and plurals #73065

merged 1 commit into from
Apr 19, 2024

Conversation

Qrox
Copy link
Contributor

@Qrox Qrox commented Apr 17, 2024

Summary

None

Purpose of change

The description for the C6 machine gun incorrectly refers to M6.

footstep is misspelled as foostep.

Report CO001141 is incorrectly pluralized by appending an s.

salt in BombasticPerks is incorrectly pluralized as salts.

Describe the solution

Fix 'em.

Describe alternatives you've considered

Testing

Just simple text edits.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Mods: Dark Days of the Dead Anything related to the DDotD mod (classic style zombies) Mods: Xedra Evolved Anything to do with Xedra Evolved Mods: Bombastic Perks labels Apr 17, 2024
@github-actions github-actions bot requested a review from Maleclypse April 17, 2024 07:33
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-requesting reviews from non-collaborators: @bombasticSlacks @I-am-Erk

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Apr 17, 2024
@github-actions github-actions bot added Lore Game lore, in-game communication. Also the Lore tab. Mods: Mind Over Matter labels Apr 17, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-requesting reviews from non-collaborators: @Standing-Storm

@Qrox Qrox changed the title Fix a typo and some awkward plurals Fix typos and awkward plurals Apr 17, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 17, 2024
@I-am-Erk
Copy link
Member

I'm not sure the fix in the gun names is right. Like if we were talking about a colt 45 revolver, it would feel proper to say "that guy has two colt 45s!", to me. Grammatically, "colts 45" might even be correct since 45 is descriptive to the proper noun. But "he's got two colt 45!" doesn't seem correct at all.

@Qrox
Copy link
Contributor Author

Qrox commented Apr 17, 2024

I think you're right. I thought pluralization like these are problematic but apparently I was conflating it with some previous discussion on pluralization of ammo names. Will update it.

@Qrox Qrox changed the title Fix typos and awkward plurals Fix typos and a plural Apr 17, 2024
@I-am-Erk
Copy link
Member

I think you're right. I thought pluralization like these are problematic but apparently I was conflating it with some previous discussion on pluralization of ammo names. Will update it.

To your credit I spent a while repeating phrases quietly over breakfast and confusing my family. It's a tricky one

@Qrox Qrox changed the title Fix typos and a plural Fix typos and plurals Apr 19, 2024
@I-am-Erk I-am-Erk merged commit 449edb2 into CleverRaven:master Apr 19, 2024
26 checks passed
@Qrox Qrox deleted the typo branch May 11, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Lore Game lore, in-game communication. Also the Lore tab. Mods: Bombastic Perks Mods: Dark Days of the Dead Anything related to the DDotD mod (classic style zombies) Mods: Mind Over Matter Mods: Xedra Evolved Anything to do with Xedra Evolved Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants