Fix ImGui keybindings screen not allowing the user to scroll the list upon opening #72871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tween "show" mode where the user can scroll the list, and filtering mode where the user can enter text into the filter text box.
github-actions
bot
added
Info / User Interface
github-actions
bot
added
the
BasicBuildPassed
akrieger
approved these changes
Apr 8, 2024
…starting/stopping filtering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Fixes ImGui keybindings UI not allowing the user to scroll"
Purpose of change
Fixes: #72598
Fixes: #72066
Describe the solution
Implemented actions in the keybindings screen to switch to "filtering" mode and back. This breaks from the original behavior of the screen because ImGui does not behave well with having the user use the arrow keys to scroll one part of the screen while also having a text field accepting text input on another part of the screen. Only one control can truly have "focus" at a time and switching focus between elements in order to have user input apply in both places like the old screen, simply is not possible.
Describe alternatives you've considered
Modifying ImGui itself to allow programmatic focusing of elements be truly "seamless" so when a user presses an arrow key, have the scrollable element focus, or when they press an alphanumeric key, focus the text field. This is currently possible but at the cost of ImGui "eating" the input that the user makes that causes the focus switch. There is simply no way around it.
Testing
Additional context
Turns out that modifying the text passed to the InputText field programmatically is a very annoying operation, and possibly requires a new version of ImGui in order to work properly.