Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forest biome terrain oter_id -> oter_type_id #72812

Merged

Conversation

Procyonae
Copy link
Contributor

@Procyonae Procyonae commented Apr 3, 2024

Summary

None

Purpose of change

Remove needless extra region setting lines specifying that all rotations of maps should count for forest density.

Describe the solution

Removes useless rotated oter_id strings.
Replaces with just oter_type_id strings.
Alphabetises the lists for good measure.

Describe alternatives you've considered

Buying a separate mouse just to scroll with.
Adding om_terrain_match_type functionality.

Testing

Start a world and find a road going through forest.
Do the same after adding "road" to "forest_thick"'s "terrains".
Forest now goes up to the road.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Map / Mapgen Overmap, Mapgen, Map extras, Map display [C++] Changes (can be) made in C++. Previously named `Code` Mods: Magiclysm Anything to do with the Magiclysm mod Mods: Dark Days of the Dead Anything related to the DDotD mod (classic style zombies) Mods: No Hope Relating to the mod No Hope Mods: Innawood 🌲 Anything to do with Innawood mod Mods: TropiCataclysm 🌴 Having to do with the tropical region mod for DDA. labels Apr 3, 2024
@github-actions github-actions bot requested a review from KorGgenT April 3, 2024 14:31
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-requesting reviews from non-collaborators: @I-am-Erk @Light-Wave @Night-Pryanik

src/mapgen_functions.cpp Outdated Show resolved Hide resolved
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Apr 3, 2024
@I-am-Erk I-am-Erk merged commit 8b4c779 into CleverRaven:master Apr 3, 2024
24 of 28 checks passed
@akrieger
Copy link
Member

akrieger commented Apr 8, 2024

So to test the crash, what I did is I moved cave_innawood out of the first slot for forest terrains, and the crash stopped happening even on the save that already had a cave generated. There's something funky that arrangement is exposing, but I can't take the time to look harder so I'm just monkeypatching the crash away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods: Dark Days of the Dead Anything related to the DDotD mod (classic style zombies) Mods: Innawood 🌲 Anything to do with Innawood mod Mods: Magiclysm Anything to do with the Magiclysm mod Mods: No Hope Relating to the mod No Hope Mods: TropiCataclysm 🌴 Having to do with the tropical region mod for DDA. Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants