[MoM] Fix Discern Weakness

[Standing-Storm]

Summary

Mods "[MoM] Fix Discern Weakness"

Purpose of change

Discern Weakness has never really worked, at first because monsters couldn't take enchantments and then because effects couldn't read the stats of the originator. But now that I know more about EoCs I know how to fix this.

Describe the solution

Rather than Discern Weakness directly applying an effect, it evokes an EoC. First it saves the psion's Intelligence, Discern Weakness power level, and Nether Attunement as variables onto the target, and then the target applies the effect on themselves with its power level derived from those variables.

Describe alternatives you've considered

Testing

Tested and works. Looks like the changes to enchant code in #73227 fixed the bugs with variable-based monster enchants.

Debugged Intelligence and power level to 50 and:

Chunky salsa

Additional context

[GuardianDll]

Fyi monsters can get enchantments now

[Standing-Storm]

Fyi monsters can get enchantments now

Right, but even after that was changed it still didn't work (because the effect saw u_spell_level('clair_spot_weakness') and went "Oh, this monster doesn't know that power" and multiplied by 0), so that's the part I need to fix.

[RedMisao]

If it works for you, effects can be detected on monsters (*) with EoCs, using the duration of the effect as a sort of internal timer from the monster's side.
At the same time, if you apply an effect -> enchantment with intermittent_activation -> spell on yourself, you can check any tagged monsters around you with the spell -> eoc, using an effect/var on the monster as condition, then force them to cast spells as u_cast_spell (**).

(*) Not sure if this is a bug or not. The doc mentions that monsters can't be the talker of u_has_effect, but it works consistently for me, using above for conditional spells, emulate disease spells and custom var acumulation over time.
(**) Would be simpler if intermittent_activation worked on monsters.

[Standing-Storm]

Unfortunately, applying this throws an error message that appears to be caused by a bug in enchant on monster code. I'll make a bug report later.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.