NPCs taking canned food donations no longer remove the food from the can #72759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
NPC / Factions
nornagon
reviewed
Apr 1, 2024
nornagon
reviewed
Apr 1, 2024
github-actions
bot
added
the
BasicBuildPassed
…ning the target item with the item asked for
katemonster33
force-pushed
the
traders_respect_cans
branch
from
508deff to
9f6ba0c
Compare
I-am-Erk
added
the
0.H Backport
Closed
Procyonae
pushed a commit
to Procyonae/Cataclysm-DDA
that referenced
this pull request
May 16, 2024
…ct_cans NPCs taking canned food donations no longer remove the food from the can
Maleclypse
added a commit
that referenced
this pull request
May 17, 2024
Procyonae
added
0.H Backported
and removed
0.H Backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "fixes issue where NPCs could take an item like canned corn as a donation and would remove the corn from the can and give you the can back."
Purpose of change
Fixes: #68456
Describe the solution
Modify f_bulk_trade_accept to look for sealed items with a single pocket that contains only the target item. If it is found, remove the item from inventory and give it to the NPC.
Describe alternatives you've considered
Testing
Spawn the New England Church Retreat, find Eddie, spawn 10x canned corn in inventory (contained), talk to Eddie and give him the 10 cans. Verify the cans and corn both end up in Eddie's inventory.
Additional context