Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MoM] Power maintenance message change #72753

Merged

Conversation

Standing-Storm
Copy link
Contributor

Summary

Mods "[MoM] Power maintenance message change"

Purpose of change

When I changed over Nether Attunement handling to an EoC, I didn't account for having a different message for channeling a power vs. concentrating on a power.

Describe the solution

Add extra EoCs to hand the message for concentrating on a power. The ID is a bit less obvious than I usually make them, but I tried to avoid JSON churn.

Describe alternatives you've considered

Testing

Channeling powers and concentrating on powers each display the appropriate Nether Attunement message.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding EOC: Effects On Condition Anything concerning Effects On Condition Mods: Mind Over Matter astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Mar 31, 2024
@Fris0uman Fris0uman merged commit a9987aa into CleverRaven:master Apr 9, 2024
26 checks passed
@Standing-Storm Standing-Storm deleted the maintenance-message-change branch April 9, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Mind Over Matter Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants