-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Mind over Matter) allow incandescent lance to repair metal items #72716
(Mind over Matter) allow incandescent lance to repair metal items #72716
Conversation
I would suggest calling the fake battery charge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-requesting reviews from non-collaborators: @Standing-Storm
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to |
was resetting the tests, ignore this |
Summary
Mods "allow incandescent lance to repair metal items"
Purpose of change
The item description mentions that the tool is able to weld, it can be used as welding tool for vehicles. So I figure it only made sense that it can be used to repair gear and tools too.
Describe the solution
Copied use_action from Arc Welder to the lance, added a pocket to the lance and "matrix charge" as the ammo. The lance doesn't use up said charge.
Describe alternatives you've considered
Making code changes to activity_handler.cpp to allow using welding tools without any charge.
Testing
Cast the psionic power, got the lance filled with matrix charge, could succesfully repair my combat machete.
Additional context
I'm drafting this so @Standing-Storm can review it, i'm not too keen on the lance using "matrix charge", as i feel that's reserved for psychic technology, not psychic powers themselves.
I feel some people might want to repair their tempered steel tools with the lance eventually, but that'd require a new variant and EOCs to handle it. So i'll just leave it as a suggestion.