Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Mind over Matter) allow incandescent lance to repair metal items #72716

Merged

Conversation

Blueflowerss
Copy link
Contributor

Summary

Mods "allow incandescent lance to repair metal items"

Purpose of change

The item description mentions that the tool is able to weld, it can be used as welding tool for vehicles. So I figure it only made sense that it can be used to repair gear and tools too.

Describe the solution

Copied use_action from Arc Welder to the lance, added a pocket to the lance and "matrix charge" as the ammo. The lance doesn't use up said charge.

Describe alternatives you've considered

Making code changes to activity_handler.cpp to allow using welding tools without any charge.

Testing

Cast the psionic power, got the lance filled with matrix charge, could succesfully repair my combat machete.

Additional context

I'm drafting this so @Standing-Storm can review it, i'm not too keen on the lance using "matrix charge", as i feel that's reserved for psychic technology, not psychic powers themselves.
I feel some people might want to repair their tempered steel tools with the lance eventually, but that'd require a new variant and EOCs to handle it. So i'll just leave it as a suggestion.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Mind Over Matter astyled astyled PR, label is assigned by github actions labels Mar 30, 2024
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Mar 30, 2024
@Standing-Storm
Copy link
Contributor

I would suggest calling the fake battery charge noetic energy to distinguish it

@Blueflowerss Blueflowerss marked this pull request as ready for review March 31, 2024 06:53
@github-actions github-actions bot added the Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves label Mar 31, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-requesting reviews from non-collaborators: @Standing-Storm

data/mods/MindOverMatter/items/ammo.json Outdated Show resolved Hide resolved
data/mods/MindOverMatter/items/ammo.json Outdated Show resolved Hide resolved
data/mods/MindOverMatter/items/ammo.json Outdated Show resolved Hide resolved
@github-actions github-actions bot removed BasicBuildPassed This PR builds correctly, label assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Mar 31, 2024
Blueflowerss and others added 2 commits March 31, 2024 07:38
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Mar 31, 2024
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Power charge for psychi phenomena.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@Blueflowerss
Copy link
Contributor Author

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.
Click to expand

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

was resetting the tests, ignore this

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 31, 2024
@I-am-Erk I-am-Erk merged commit 5a377d9 into CleverRaven:master Apr 4, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Mind Over Matter Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants