-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enchantment tests #72681
Merged
Merged
Enchantment tests #72681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
Changes (can be) made in JSON
Code: Tests
Measurement, self-control, statistics, balancing.
[C++]
Changes (can be) made in C++. Previously named `Code`
Mechanics: Enchantments / Spells
Enchantments and spells
astyled
astyled PR, label is assigned by github actions
json-styled
JSON lint passed, label assigned by github actions
labels
Mar 28, 2024
This was referenced Mar 29, 2024
Merged
Why my new test pass, but the old enchantment tests suddenly do not? |
GuardianDll
force-pushed
the
ench_tests
branch
2 times, most recently
from
March 30, 2024 11:47
4d22dd6
to
241b2b0
Compare
github-actions
bot
removed
the
astyled
astyled PR, label is assigned by github actions
label
Mar 30, 2024
…th test operation order. Also various fixes
github-actions
bot
added
the
astyled
astyled PR, label is assigned by github actions
label
Mar 30, 2024
github-actions
bot
added
BasicBuildPassed
This PR builds correctly, label assigned by github actions
and removed
astyled
astyled PR, label is assigned by github actions
labels
Mar 30, 2024
github-actions
bot
added
astyled
astyled PR, label is assigned by github actions
and removed
BasicBuildPassed
This PR builds correctly, label assigned by github actions
labels
Mar 31, 2024
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Apr 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
[C++]
Changes (can be) made in C++. Previously named `Code`
Code: Tests
Measurement, self-control, statistics, balancing.
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Mechanics: Enchantments / Spells
Enchantments and spells
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Set of tests, that cover our enchantments
Describe the solution
Tried to base my work on #63034, but because of my low level of c++ and giant amount of errors in the original PR decided to scrap it and make stuff from zero
Testing
Autotests
Additional context
All tests worked yesterday, but then i changed a few stuff and now nothing is working