Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enchantment tests #72681

Merged
merged 16 commits into from
Apr 10, 2024
Merged

Enchantment tests #72681

merged 16 commits into from
Apr 10, 2024

Conversation

GuardianDll
Copy link
Member

Summary

None

Purpose of change

Set of tests, that cover our enchantments

Describe the solution

Tried to base my work on #63034, but because of my low level of c++ and giant amount of errors in the original PR decided to scrap it and make stuff from zero

Testing

Autotests

Additional context

All tests worked yesterday, but then i changed a few stuff and now nothing is working

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Code: Tests Measurement, self-control, statistics, balancing. [C++] Changes (can be) made in C++. Previously named `Code` Mechanics: Enchantments / Spells Enchantments and spells astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Mar 28, 2024
@GuardianDll GuardianDll marked this pull request as ready for review March 29, 2024 18:55
@GuardianDll
Copy link
Member Author

Why my new test pass, but the old enchantment tests suddenly do not?

@GuardianDll GuardianDll force-pushed the ench_tests branch 2 times, most recently from 4d22dd6 to 241b2b0 Compare March 30, 2024 11:47
tests/enchantments_test.cpp Outdated Show resolved Hide resolved
tests/enchantments_test.cpp Outdated Show resolved Hide resolved
tests/enchantments_test.cpp Outdated Show resolved Hide resolved
tests/enchantments_test.cpp Outdated Show resolved Hide resolved
tests/enchantments_test.cpp Outdated Show resolved Hide resolved
tests/enchantments_test.cpp Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the astyled astyled PR, label is assigned by github actions label Mar 30, 2024
…th test operation order. Also various fixes
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Mar 30, 2024
@github-actions github-actions bot added BasicBuildPassed This PR builds correctly, label assigned by github actions and removed astyled astyled PR, label is assigned by github actions labels Mar 30, 2024
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions and removed BasicBuildPassed This PR builds correctly, label assigned by github actions labels Mar 31, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 7, 2024
@dseguin dseguin merged commit d33a6c7 into CleverRaven:master Apr 10, 2024
22 of 27 checks passed
@GuardianDll GuardianDll deleted the ench_tests branch April 10, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Code: Tests Measurement, self-control, statistics, balancing. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mechanics: Enchantments / Spells Enchantments and spells
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants