Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly obsolete aftershock obsoletion #72671

Merged
merged 2 commits into from
Mar 31, 2024

Conversation

GuardianDll
Copy link
Member

Summary

None

Purpose of change

While replacing mutations fields with enchantments, the biggest amount of work i did was fixing mutation fields, that wasn't properly obsoleted (because throwing item in the obsoletion folder is not an obsoletion)

Describe the solution

Properly obsolete stuff
I liked afs manuals, so i moved them to vanilla as variants

Testing

Power of autotests

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Mods: Aftershock Anything to do with the Aftershock mod labels Mar 28, 2024
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Mar 28, 2024
@github-actions github-actions bot added Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies BasicBuildPassed This PR builds correctly, label assigned by github actions labels Mar 29, 2024
@Maleclypse Maleclypse merged commit 0a665e7 into CleverRaven:master Mar 31, 2024
21 of 24 checks passed
@GuardianDll GuardianDll deleted the aftershock_obsoletion branch March 31, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Aftershock Anything to do with the Aftershock mod Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants