Adds impossible geometric shape artifacts, places them in distorted labs

[carlarctg]

Summary

Content "Adds a new set of twisted geometry artifacts, found where geometry itself is twisted due to the acts of humans and worse."

Purpose of change

I noticed that there weren't any actual impossible shapes in our array of impossible items, so I sought to fix that by adding shapes which are possible to represent in 2D but impossible in 3D.

Additionally, the distorted lab artifacts are fiine, but they're also kind of.. dull? Like, they're just normal artifacts. This is something unique and cool that replaces them as a reward which fits better.

Describe the solution

The artifacts in the distorted lab are now of the 'twisted geometry' kind.

Twisted geometry artifacts' effects are physics-related: Force push, light, weight capacity, speed, etc. Generally, they have more impactful positive and negative effects, while also having lower resonance than usual. This is because unlike other artifacts they are still of our reality - they've just been twisted and altered, rotten and broken remnants of what remains from the lattice of reality that have been torn off and discarded. As a tradeoff, most of their item types are rather bulky and difficult to carry. Being too big, too heavy, too long. This is why they have such weird weight, volume, and side values. Reality clearly isn't working here, why should their dimensions conform to human standards?

Describe alternatives you've considered

No

Testing

Spawned in, tele'd to a physics lab, ensured everything spawns properly. Spawned an artifact in manually and tested it.

Additional context

The altered objects' lore implies that they are somehow manifestations of the excursion teams' minds. In my mind, there's something similar going on here: The eggheads at the physics lab had their minds full of weird physical anomalies and when reality broke down whatever mechanism generates artifacts took inspiration from that.

Actual artifact item types:

Bomorrean Rings:
Three rings interlocked together in an impossible way. Identical stat-wise to the ring artifact.

Penrose Triangle: 2 liters, 2 kilograms.

Impossible Trident: It's an actual trident! Stats copied and edited from Aftershock's trident.

Klein Bottle: Weightless. Contains a pocket that you can somehow reach into. Bacteria can't, so food spoils half as quickly. Items inside are also weightless, but reaching inside the bottle (somehow) is very time-consuming.

Tesseract: 1 L, but contains the weight of 8 (kg) cubes inside it.

Irrational Cube: 1 L, weightless, 30 cm for the longest side.

Duocylinder: 250 ml, 8 kg (8 spheres!), longest side is zero cm. This is intentional, unless it causes problems.

[NetSysFire]

miiiight be out of scope but repeating It is the only one of its kind.\nIt may have unknown powers; try activating them. over and over seems a bit inefficient and these should be made flags. e.g ARTIFACT_UNIQUE and ARTIFACT_ACTIVATABLE.

[github-actions]

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand

• A chunky ring that folds onto itself continously, preventing its use as an esoteric piece of jewelry. It is the only one of its kind.\nIt may have unknown powers; try activating them.
• A large triangle made out of three thick rectangles that connect to eachother in an angle. No matter how much you turn it around, you can't seem to comprehend how it links together. It is the only one of its kind.\nIt may have unknown powers; try activating them.
• A large trident made entirely out of an indiscernable material. The prong in the middle seems to fade away into nothingness when looked at from the top, but you can clearly see the shaft connecting the tip of the weapon from the bottom. It's giving you a headache. It is the only one of its kind.\nIt may have unknown powers; try activating them.
• A set of three rings linked together. There's something about the way the rings connect to eachother that gives you a headache. It is the only one of its kind.\nIt may have unknown powers; try activating them.
• It's a cube that constantly shrinks and grows in size. It's two cubes linked by the vertices, with ever-shifting sides folding onto eachother, over and over. It's four cubes in the exact same position. It's a cube fading to ash then reverting to pristine form repeatedly. It's all of these at once, and none of them at all. It is the only one of its kind.\nIt may have unknown powers; try activating them.
• set of oddly interlocked ringss

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary

• If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
• For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

[I-am-Erk]

these are failing some item volume tests, they might need to be blacklisted from those tests since they are impossibly shaped.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

[anoobindisguise]

hey this has already been merged but as this makes the "netherum_tunnels" artifacts unobtainable, should these spawn in addition to that group in the distorted lab? mix the pools? I can do that PR separately, just wanted to hear the author's thoughts.

[Maleclypse]

Probably best to mix the pools for now. Unless the original author decides to speak on it.

…

On Thu, Jul 11, 2024 at 6:17 PM anoobindisguise ***@***.***> wrote: hey this has already been merged but as this makes the "netherum_tunnels" artifacts unobtainable, should these spawn in addition to that group in the distorted lab? mix the pools? I can do that PR separately, just wanted to hear the author's thoughts. — Reply to this email directly, view it on GitHub <#72605 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AM6UAQDTETE2IJAOJJ4ESMDZL4HAXAVCNFSM6AAAAABFGKJARCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRUGEYDINRYGU> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>

-- C