Fixed an issue where the ImGui popup window steals focus when not on top #72604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[C++]
katemonster33
force-pushed
the
imgui_popup_focus_stealing
branch
from
6972b61 to
51c9de8
Compare
github-actions
bot
added
the
BasicBuildPassed
SurFlurer
added a commit
to SurFlurer/Cataclysm-DDA
that referenced
this pull request
Aug 26, 2024
… not on top (CleverRaven#72604)" This reverts commit e442936.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "ImGui popup was stealing window focus when another window was on top of it"
Purpose of change
Fixes: #72600
Describe the solution
Popup had code baked in to try and make sure a button was focused - don't let that code execute when the window is not focused
Describe alternatives you've considered
Testing
Open main menu, click "World", select any world, try to delete it, and when the popup shows asking if you're sure, press '?' key to open keybindings. Verify that the keybindings screen remains focused.
Additional context