Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a gun-less variant of mansion safe item group and use it in the resort. #72595

Merged
merged 3 commits into from
Mar 29, 2024

Conversation

kevingranade
Copy link
Member

Summary

None

Purpose of change

While tracking down the source of some excessively common gun spawns I found that a ton of guns were spawning in the safe deposit boxes in the resort. Looks like "mansion_safe" is being used as a standin for "rich people stuff".

Describe the solution

Add a variant of the mansion_safe item group without guns and apply it to the resort.

Describe alternatives you've considered

There could be a special gun lockup placement as well (with much smaller numbers of guns).
The mansion_safe group isn't really a great match for this kind of thing and a replacement would be good, but this was the minimal change to fix the immediate problem I was having.

Testing

Generated some resorts and no guns, yay.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Spawn Creatures, items, vehicles, locations appearing on map json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Mar 24, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 28, 2024
@Maleclypse Maleclypse merged commit ca74127 into master Mar 29, 2024
20 of 24 checks passed
@Maleclypse Maleclypse deleted the gun-less-safes branch March 29, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants