Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding imgui_demo.cpp to CMake build to fix build errors #72533

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Adding imgui_demo.cpp to CMake build to fix build errors #72533

merged 1 commit into from
Mar 22, 2024

Conversation

katemonster33
Copy link
Contributor

Summary

Bugfixes "Fixing cmake build that was failing due to not compiling imgui_demo.cpp in"

Purpose of change

build matrix CI is failing due to cmake build not being updated for the change to have the ImGui demo screen display from the main menu. this fixes that.

Describe the solution

Change CMakeLists.txt to include the missing cpp file

Describe alternatives you've considered

watching the world burn

Testing

mkdir build; cd build; cmake .. && make -j12

Additional context

@github-actions github-actions bot added Code: Build Issues regarding different builds and build environments <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Mar 21, 2024
@Maleclypse Maleclypse merged commit 54d9f4c into CleverRaven:master Mar 22, 2024
26 checks passed
SurFlurer added a commit to SurFlurer/Cataclysm-DDA that referenced this pull request Aug 26, 2024
@SurFlurer
Revert "Merge pull request CleverRaven#72533 from katemonster33/imgui…
6ac9f09 
…_cmake_build_error"

This reverts commit 54d9f4c, reversing
changes made to 3138100.
this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Code: Build Issues regarding different builds and build environments json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@katemonster33 @Maleclypse